Switch from derivative to derive-where
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Nov 11, 2024
`derivative` is marked as unmaintained by RUSTSEC but still used in Charon. We exclude it from the deny check until `derivative` is replaced in Charon (AeneasVerif/charon#459). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
|
Thank you, this is a welcome change! Could you commit the updated |
|
|
|
I'm getting "note: an implementation of |
Nadrieril
force-pushed
the
derive-where
branch
from
6ddb161
to
b9fd144
Compare
|
I see, there was a typo. I have fixed this but please run tests before submitting a PR next time. |
|
Ended up switching to a manual impl in the end. Should be good, let me know if there are other dependencies that are problematic for kani! |
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Nov 14, 2024
Reverts #3708 The issue of `derivative` has been fixed in Charon: AeneasVerif/charon#459. Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derivative has not been maintained in 3 years and recently been marked as unmaintained by RUSTSEC (https://rustsec.org/advisories/RUSTSEC-2024-0388).
This PR replaces
derivativewithderive-where, a not dead alternative.